Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more explicit error confirmation for http query route error. #15621

Merged
merged 2 commits into from
Jun 5, 2024
Merged

refactor: more explicit error confirmation for http query route error. #15621

merged 2 commits into from
Jun 5, 2024
+100 −51

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented May 23, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

also including the case that server restart (assert: always with new node_id).
we can tell it from query timeout at once.

  • need to test with the clients
    • go
    • java
    • bendsql
    • py

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 23, 2024
@youngsofun youngsofun marked this pull request as draft May 23, 2024 01:54
@youngsofun youngsofun force-pushed the next branch 8 times, most recently from 92dfc8c to 6cd1c62 Compare May 27, 2024 09:16
@youngsofun youngsofun marked this pull request as ready for review May 27, 2024 10:33
@youngsofun youngsofun requested a review from hantmac May 28, 2024 00:25
flaneur2020
flaneur2020 requested changes May 29, 2024
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it need a comprehensive test over all the drivers after api route changes, and there're also a few in-house query clients (like PHP) not using our drivers at all. if it's an enhancement over the error message, i guess we can consider a less invasive way to make it.

@youngsofun youngsofun force-pushed the next branch 3 times, most recently from fb286d0 to 1958601 Compare May 29, 2024 12:57
@youngsofun
Copy link
Member Author

@flaneur2020 plz review again

@youngsofun youngsofun mentioned this pull request May 30, 2024
Merged
flaneur2020
flaneur2020 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@flaneur2020 flaneur2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngsofun youngsofun added this pull request to the merge queue Jun 5, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jun 5, 2024
@BohuTANG BohuTANG merged commit 159a8b8 into databendlabs:main Jun 5, 2024
69 checks passed
This was referenced Jul 14, 2024
Closed
Closed
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@flaneur2020 flaneur2020 flaneur2020 approved these changes

@hantmac hantmac Awaiting requested review from hantmac

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngsofun @flaneur2020 @sundy-li @BohuTANG